Correct a flaw in the Python 3 version checking (for 2.1) #12636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out the ax_python_devel.m4 version check assumes that
("3.X+1.0" >= "3.X.0") is True in Python, which is not when X+1
is 10 or above and X is not. (Also presumably X+1=100 and ...)
So let's remake the check to behave consistently, using the
"packaging" or (if absent) the "distlib" modules.
(Also, update the Github workflows to use the new packages.)
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes: openzfs#12073
behlendorf
added
Status: Code Review Needed
13 tasks
|
Note that Fedora 35 is scheduled to be released on the 26th, would be nice if this can get into a stable release before then. |
This was referenced Oct 22, 2021
tonyhutter
approved these changes
Oct 27, 2021
behlendorf
approved these changes
Nov 1, 2021
ghost
pushed a commit
to truenas/zfs
that referenced
this pull request
Nov 3, 2021
It turns out the ax_python_devel.m4 version check assumes that
("3.X+1.0" >= "3.X.0") is True in Python, which is not when X+1
is 10 or above and X is not. (Also presumably X+1=100 and ...)
So let's remake the check to behave consistently, using the
"packaging" or (if absent) the "distlib" modules.
(Also, update the Github workflows to use the new packages.)
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes: openzfs#12073
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
As keeps happening, someone in IRC said "hey, 2.1.1 breaks building on my Fedora 35 system".
Description
I cherrypicked 08cd071, cleaned up the .github conflicts, and here we are.
(Yes I remember this comment about it still being broken in some cases, I'll go correct that Soon(tm), but since this fixes many people right now, it seemed worthwhile to pull now...)
How Has This Been Tested?
I applied it to zfs-2.1-release and built on Fedora 34 (3.9.X) and -next (3.10.0). Built fine after.
I have admittedly not run through any of the pyzfs test suite bits.
Types of changes
Checklist:
Signed-off-by.